Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOW] Subgraph deploy matrix #2003

Merged
merged 24 commits into from
Aug 28, 2024
Merged

[WORKFLOW] Subgraph deploy matrix #2003

merged 24 commits into from
Aug 28, 2024

Conversation

mmd-afegbua
Copy link
Collaborator

@mmd-afegbua mmd-afegbua commented Aug 8, 2024

Copy link

github-actions bot commented Aug 8, 2024

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (349f760) to head (9fe607e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2003   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files         111      111           
  Lines        6964     6969    +5     
  Branches      934      934           
=======================================
+ Hits         6159     6164    +5     
  Misses        803      803           
  Partials        2        2           
Flag Coverage Δ
ethereum-contracts 94.50% <ø> (ø)
sdk-core 88.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmd-afegbua mmd-afegbua marked this pull request as ready for review August 8, 2024 17:10
@mmd-afegbua mmd-afegbua requested review from d10r and removed request for hellwolf and kasparkallas August 8, 2024 17:10
@mmd-afegbua mmd-afegbua marked this pull request as draft August 12, 2024 12:34
@mmd-afegbua mmd-afegbua marked this pull request as ready for review August 14, 2024 09:06
Copy link
Collaborator

@d10r d10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves logic from scripts (deploy.sh) to workflow files, specifically the list of networks per vendor.
That violates the principle that workflows shall not contain more logic than necessary, such that they don't become the only way to execute tasks.

@mmd-afegbua
Copy link
Collaborator Author

This moves logic from scripts (deploy.sh) to workflow files, specifically the list of networks per vendor. That violates the principle that workflows shall not contain more logic than necessary, such that they don't become the only way to execute tasks.

The logic introduced is the matrix for the list of network for each vendor, which had been previously handled by deploy.sh. deploy.sh can still execute the deployment task, just that if it is being used outside of the workflow, one is expected to know the vendor and networks that are supported there. This way, you dont't have to make changes to the deploy script if for instance, you want to experiment with a new network.

@mmd-afegbua mmd-afegbua force-pushed the subgraph-deploy-matrix branch from 3b4e13b to 521dca9 Compare August 22, 2024 11:53
@hellwolf
Copy link
Contributor

@d10r

@hellwolf hellwolf requested a review from a team as a code owner August 26, 2024 17:59
@d10r
Copy link
Collaborator

d10r commented Aug 27, 2024

We didn't manage to fix the failing test here, thus it's not required anymore (after consulting with @kasparkallas ).

Could be improved: when deploying to multiple networks, run only the deploy step for each.

@d10r d10r merged commit c887de9 into dev Aug 28, 2024
20 checks passed
@d10r d10r deleted the subgraph-deploy-matrix branch August 28, 2024 07:28
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2003
https://xkcd.com/2003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SUBGRAPH WORKFLOWS] Use matrix for multi-vendor|network deployment
3 participants