-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WORKFLOW] Subgraph deploy matrix #2003
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2003 +/- ##
=======================================
Coverage 88.44% 88.44%
=======================================
Files 111 111
Lines 6964 6969 +5
Branches 934 934
=======================================
+ Hits 6159 6164 +5
Misses 803 803
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moves logic from scripts (deploy.sh) to workflow files, specifically the list of networks per vendor.
That violates the principle that workflows shall not contain more logic than necessary, such that they don't become the only way to execute tasks.
The logic introduced is the matrix for the list of network for each vendor, which had been previously handled by |
3b4e13b
to
521dca9
Compare
We didn't manage to fix the failing test here, thus it's not required anymore (after consulting with @kasparkallas ). Could be improved: when deploying to multiple networks, run only the deploy step for each. |
XKCD Comic RelifLink: https://xkcd.com/2003 |
Sample run: https://github.com/superfluid-finance/protocol-monorepo/actions/runs/10580677816