Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted test improvements 20240701 #1971

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Jul 1, 2024

Porting changeset away from batch-ops:

  • upgrade foundry version
  • rename '.prop.sol' to '.prop.t.sol'
  • fix a few types and build warnings

@hellwolf hellwolf requested review from d10r and a team as code owners July 1, 2024 18:46
Copy link

github-actions bot commented Jul 1, 2024

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@hellwolf hellwolf enabled auto-merge July 1, 2024 19:08
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.60%. Comparing base (4c86d26) to head (5fceaf1).

Files Patch % Lines
...m-contracts/contracts/apps/SuperTokenV1Library.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1971      +/-   ##
==========================================
+ Coverage   88.18%   88.60%   +0.41%     
==========================================
  Files         118      118              
  Lines        7357     7360       +3     
  Branches      966      966              
==========================================
+ Hits         6488     6521      +33     
+ Misses        867      837      -30     
  Partials        2        2              
Flag Coverage Δ
ethereum-contracts 94.21% <0.00%> (+0.80%) ⬆️
sdk-core 88.60% <0.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf hellwolf added this pull request to the merge queue Jul 1, 2024
Merged via the queue into dev with commit f113f5e Jul 1, 2024
19 of 20 checks passed
@hellwolf hellwolf deleted the assorted-test-improvements-20240701 branch July 1, 2024 21:10
Copy link

github-actions bot commented Jul 1, 2024

XKCD Comic Relif

Link: https://xkcd.com/1971
https://xkcd.com/1971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] Get rid of compiler warnings
2 participants