Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOMATIONS] Vesting Scheduler - add claimable schedule feature #1944

Merged
merged 44 commits into from
Jun 10, 2024
Merged

[AUTOMATIONS] Vesting Scheduler - add claimable schedule feature #1944

Show file tree
Hide file tree
Changes from 43 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
e3a1013
allow creation and execution of the vesting schedule in the current b…
kasparkallas Mar 19, 2024
2a4f363
add createVestingSchedule function which works with totalAmount and t…
kasparkallas Mar 21, 2024
552a3df
add overloads without ctx
kasparkallas Mar 21, 2024
ad7ce58
add more overloads with fewer parameters
kasparkallas Mar 21, 2024
b9ee878
reorganize the functions
kasparkallas Mar 22, 2024
89a173a
add create and execute schedule mvp
kasparkallas Mar 22, 2024
b9464fb
remove try-catch from early end
kasparkallas Mar 26, 2024
648c5bf
add dust amount fix (wip)
kasparkallas Mar 26, 2024
adb07a5
Merge remote-tracking branch 'origin/dev' into vesting-scheduler-1_2
kasparkallas Mar 26, 2024
59832dc
rename from dustFixAmount to remainderAmount
kasparkallas Mar 26, 2024
96d06fa
fix test issues
kasparkallas Mar 27, 2024
9cce7cf
tiny comment rename
kasparkallas Mar 27, 2024
d5cdaca
Merge remote-tracking branch 'origin/dev' into vesting-scheduler-1_2
kasparkallas Apr 1, 2024
3c3c09c
remove functions create and execute functions with cliff period
kasparkallas Apr 1, 2024
78dc300
add a comprehensive fuzzed test for createScheduleFromAmountAndDuration
kasparkallas Apr 2, 2024
cd264e5
slightly change end compensation & remainder handling
kasparkallas Apr 3, 2024
4af5726
Merge branch 'dev' into vesting-scheduler-1_2
kasparkallas Apr 8, 2024
5997eed
Merge branch 'dev' into vesting-scheduler-1_2
kasparkallas Apr 10, 2024
bd008a2
keep V1 contract, separate V2 explicitly
kasparkallas Apr 10, 2024
5c75550
update deploy script for v2
kasparkallas Apr 10, 2024
a5239ce
Merge remote-tracking branch 'origin/dev' into vesting-scheduler-1_2
kasparkallas Apr 29, 2024
bfbefa1
unify deploy scripts
kasparkallas Apr 29, 2024
2bdd112
use newer host.registerApp & unify deploy scripts
kasparkallas Apr 30, 2024
cb84d33
clean-up
kasparkallas May 16, 2024
b08d7d0
added claimable vesting feature
0xPilou May 21, 2024
e353ccc
add check on `_executeCliffAndFlow` for claimable schedules
0xPilou May 21, 2024
cd6c5f4
updated time window condition on schedule claim
0xPilou May 22, 2024
3750f31
fix typo
0xPilou May 22, 2024
1d2b08d
add some unit tests for claiming schedules
0xPilou May 22, 2024
23e99f7
increased test coverage
0xPilou May 22, 2024
00231b2
added claimValidityDate feature
0xPilou May 23, 2024
1326329
updated tests
0xPilou May 23, 2024
356949a
add claimValidityDate param to createSchedules function
0xPilou May 24, 2024
17c382c
updated unit tests
0xPilou May 24, 2024
9c2b664
refactor internal function params (stack too deep) + add claimValidit…
0xPilou May 24, 2024
3da96a3
removed `isClaimable` boolean from VestingSchedule data structure
0xPilou May 27, 2024
0485804
remove internal function creating dupplication
0xPilou May 27, 2024
dac59ef
updated claim validity date check logic
0xPilou May 30, 2024
e757797
refactor: re-order the claimValidityDate in the event
kasparkallas Jun 5, 2024
1c4524e
refactor: rename error
kasparkallas Jun 6, 2024
de5d262
chore: merge
kasparkallas Jun 10, 2024
d7f2a5a
fix: remove merge issues from hardhat configs
kasparkallas Jun 10, 2024
9934341
fix: remove duplication from hardhat config
kasparkallas Jun 10, 2024
de2d7c3
fix: moved & rename params struct into VestingSchedulerV2 contract
0xPilou Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/automation-contracts/autowrap/hardhat.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = {
process.env.PRIVATE_KEY !== undefined
? [process.env.PRIVATE_KEY]
: [],
gasPrice: 1000000000
gasPrice: 1000000000,
},
},
namedAccounts: {
Expand Down
4 changes: 2 additions & 2 deletions packages/automation-contracts/scheduler/contracts/VestingScheduler.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ contract VestingScheduler is IVestingScheduler, SuperAppBase {
uint32 public constant START_DATE_VALID_AFTER = 3 days;
uint32 public constant END_DATE_VALID_BEFORE = 1 days;

constructor(ISuperfluid host, string memory registrationKey) {
constructor(ISuperfluid host) {
cfaV1 = CFAv1Library.InitData(
host,
IConstantFlowAgreementV1(
Expand All @@ -37,7 +37,7 @@ contract VestingScheduler is IVestingScheduler, SuperAppBase {
SuperAppDefinitions.AFTER_AGREEMENT_UPDATED_NOOP |
SuperAppDefinitions.BEFORE_AGREEMENT_TERMINATED_NOOP |
SuperAppDefinitions.AFTER_AGREEMENT_TERMINATED_NOOP;
host.registerAppWithKey(configWord, registrationKey);
host.registerApp(configWord);
}

/// @dev IVestingScheduler.createVestingSchedule implementation.
Expand Down
Loading
Loading