MacroForwarderERC712 Version #1798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hellwolf
commented
Jan 22, 2024
•
hellwolf
commented
- ✅ MacroForwarder Vanilla Version #1786 must be merged first.
- This implements a EIP-712 version of [ETHEREUM-CONTRACTS] TrustedMacros: A TrustedForwarder that rules them all #1782 .
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
8 tasks
hellwolf
changed the title
|
Instead, the new idiomatic way forward is that eip-712 support macro should simply be built as part of the regular macro. See SuperBoring example: https://github.com/superfluid-finance/averageX/pull/219 |
mostafaadel33
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.