[NETWORK] added optimism-sepolia, scroll-sepolia, scroll-mainnet #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
d10r
force-pushed
the
optimism-sepolia-deploy
branch
from
81659c3 to
4e1705e
Compare
d10r
force-pushed
the
optimism-sepolia-deploy
branch
from
4e1705e to
b09efc3
Compare
d10r
requested review from
0xdavinchee,
kasparkallas,
hellwolf,
ngmachado,
vmichalik,
philipandersson and
a team
as code owners
* add scroll networks * add scroll sepolia to metadata * add scroll mainnet to metadata --------- Co-authored-by: isabelle <[email protected]>
d10r
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1787 +/- ##
==========================================
- Coverage 74.45% 74.44% -0.02%
==========================================
Files 109 109
Lines 5873 5873
Branches 216 216
==========================================
- Hits 4373 4372 -1
- Misses 1450 1451 +1
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
why nix.flake was updated? |
good question, hadn't noticed. |
hellwolf
approved these changes
Jan 19, 2024
for the forwarders yes |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
XKCD Comic RelifLink: https://xkcd.com/1787 |
hellwolf
pushed a commit
that referenced
this pull request
Jan 23, 2024
* apply diff * updated changelog * [ETHEREUM-CONTRACTS] add scroll-mainnet and scroll-sepolia (#1790) * add scroll networks * add scroll sepolia to metadata * add scroll mainnet to metadata --------- Co-authored-by: isabelle <[email protected]> * added metadata, updated changelog * added subgraph metadata * undo flake.lock change --------- Co-authored-by: isabelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contracts deployed.
TBD:
[X] bump metadata version
[X] add to subgraph package (implied by adding to metadata?)