Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACT] add deployment view of Superfluid framework #1776

Merged
merged 11 commits into from
Jan 11, 2024

Conversation

hellwolf
Copy link
Contributor

No description provided.

@hellwolf hellwolf marked this pull request as ready for review January 11, 2024 12:00
@hellwolf hellwolf requested a review from 0xdavinchee as a code owner January 11, 2024 12:00
@hellwolf hellwolf requested a review from a team as a code owner January 11, 2024 12:06
@d10r
Copy link
Collaborator

d10r commented Jan 11, 2024

piggy-backed #1765

Copy link

📦 PR Packages

Install this PR (you need to setup Github packages):

yarn add @superfluid-finance/ethereum-contracts@PR1776
yarn add @superfluid-finance/sdk-core@PR1776
yarn add @superfluid-finance/sdk-redux@PR1776
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your .npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@hellwolf hellwolf enabled auto-merge January 11, 2024 13:01
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f4bdc6) 74.45% compared to head (886ec19) 74.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1776   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files         109      109           
  Lines        5873     5873           
  Branches      216      216           
=======================================
  Hits         4373     4373           
  Misses       1450     1450           
  Partials       50       50           
Flag Coverage Δ
ethereum-contracts 65.53% <ø> (ø)
sdk-core 82.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf hellwolf added this pull request to the merge queue Jan 11, 2024
Merged via the queue into dev with commit 71af766 Jan 11, 2024
42 of 43 checks passed
@hellwolf hellwolf deleted the docs-add-protocol-deployment-view branch January 11, 2024 20:36
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1776
https://xkcd.com/1776

hellwolf added a commit that referenced this pull request Jan 23, 2024
* take relative path

* skip FlowNFT contracts if not deployed

* undo: disable sdk-redux build

* [ETHEREUM-CONTRACT] add deployment view of Superfluid framework

* fix flaky test

* [ETHEREUM-CONTRACTS] docs: update deployment-view.drawio

* [ETHEREUM-CONTRACTS] docs: update deployment-view.drawio

* update foundry nix input

---------

Co-authored-by: didi <[email protected]>
Co-authored-by: 0xdavinchee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants