Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] SuperApp registerApp deprecation #1706

Merged
merged 19 commits into from
Oct 9, 2023
Merged

[ETHEREUM-CONTRACTS] SuperApp registerApp deprecation #1706

merged 19 commits into from
Oct 9, 2023

Conversation

0xdavinchee
Copy link
Contributor

No description provided.

@0xdavinchee 0xdavinchee requested a review from d10r September 29, 2023 08:37
@0xdavinchee 0xdavinchee self-assigned this Sep 29, 2023
@0xdavinchee 0xdavinchee linked an issue Sep 29, 2023 that may be closed by this pull request
[ETHEREUM-CONTRACTS] [DEVX] simplify SuperApp registration #1660
Closed
@github-actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@hellwolf hellwolf marked this pull request as draft October 3, 2023 09:03
@d10r d10r marked this pull request as ready for review October 6, 2023 07:05
@d10r d10r marked this pull request as draft October 6, 2023 07:16
@hellwolf hellwolf mentioned this pull request Oct 6, 2023
Closed
@0xdavinchee
cleanup
4ef131a 
- fix broken tests
- remove unused app jail reasons from codebase
@0xdavinchee
Merge branch 'super-app-registration-deprecation' of github.com:super…
db62d2d 
…fluid-finance/protocol-monorepo into super-app-registration-deprecation
@0xdavinchee
fix signature
e0a1454
@0xdavinchee
Merge branch 'dev' into super-app-registration-deprecation
1271351
@0xdavinchee
Merge branch 'super-app-registration-deprecation' of github.com:super…
74f4120 
…fluid-finance/protocol-monorepo into super-app-registration-deprecation
@d10r d10r marked this pull request as ready for review October 8, 2023 08:15
hellwolf
hellwolf approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry then we are good to go

@0xdavinchee
Update CHANGELOG.md
c2a277b
@0xdavinchee
Merge branch 'super-app-registration-deprecation' of github.com:super…
478e9db 
…fluid-finance/protocol-monorepo into super-app-registration-deprecation
@0xdavinchee 0xdavinchee enabled auto-merge October 9, 2023 08:49
@0xdavinchee 0xdavinchee added this pull request to the merge queue Oct 9, 2023
Merged via the queue into dev with commit 7a4f969 Oct 9, 2023
@0xdavinchee 0xdavinchee deleted the super-app-registration-deprecation branch October 9, 2023 10:29
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

XKCD Comic Relif

Link: https://xkcd.com/1706
https://xkcd.com/1706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d10r d10r d10r approved these changes

@hellwolf hellwolf hellwolf approved these changes

Assignees

@0xdavinchee 0xdavinchee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] [DEVX] simplify SuperApp registration
3 participants
@0xdavinchee @hellwolf @d10r