fix tests to fuzz with different pool configs and fix distributeFlow …

…blocked liquidation issue
superfluid-finance · Nov 6, 2023 · 50c3ccf · 50c3ccf
1 parent 081415f
commit 50c3ccf
Show file tree

Hide file tree

Showing 2 changed files with 242 additions and 179 deletions.
diff --git a/packages/ethereum-contracts/contracts/agreements/gdav1/GeneralDistributionAgreementV1.sol b/packages/ethereum-contracts/contracts/agreements/gdav1/GeneralDistributionAgreementV1.sol
@@ -475,7 +475,10 @@ contract GeneralDistributionAgreementV1 is AgreementBase, TokenMonad, IGeneralDi
 
         newCtx = ctx;
 
-        if (!pool.distributionFromAnyAddress()) {
+        // we must check if the requestedFlowRate is greater than 0 here
+        // otherwise we will block liquidators from closing streams in pools
+        // where the pool config has distributionFromAnyAddress set to false
+        if (requestedFlowRate > 0 && !pool.distributionFromAnyAddress()) {
             if (pool.admin() != flowVars.currentContext.msgSender) {
                 revert GDA_DISTRIBUTE_FROM_ANY_ADDRESS_NOT_ALLOWED();
             }