Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Claimable Vesting Schedule feature #17

Conversation

0xPilou
Copy link
Contributor

@0xPilou 0xPilou commented May 31, 2024

This Graph updates works includes :

  • Added claimValidityDate to entity VestingScheduleCreatedEvent and VestingSchedule
  • Updated mapping to :
  1. include claimValidityDate to relevant entities
  2. skip cliffAndFlowTask creation when a schedule is claimable

This updated graph version is deployed here

mmd-afegbua and others added 30 commits April 29, 2024 10:36
…nize-clean-up-deps-and-ci

modernize and clean-up deps & ci
…correct-op-sepolia-cli-name

use correct op-sepolia name
…gas-used-to-events

Add `gasUsed` to execution events
…addresses-mapping-for-wrap-events

fix addresses mapping for wrap schedules
@0xPilou 0xPilou marked this pull request as ready for review June 3, 2024 07:33
@kasparkallas kasparkallas self-requested a review June 3, 2024 12:59
- was having issue with VestingScheduleCreated not being assignable to VestingScheduleCreated_v2
Copy link
Collaborator

@kasparkallas kasparkallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I merged master in here. I had a bit of an issue with VestingSchedulerCreated mapper function not working with the same type for both v1 and v2. AssemblyScript and The Graph Tooling is very strict and limited with types in some cases. Union types, parent interfaces, stuff like that is also unfortunately not possible.

@kasparkallas kasparkallas merged commit 732df4e into superfluid-finance:vesting-scheduler-1_2 Jun 10, 2024
@kasparkallas kasparkallas mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants