Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate PyPI action #813

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Automate PyPI action #813

merged 1 commit into from
Aug 29, 2023

Conversation

nenb
Copy link
Contributor

@nenb nenb commented Aug 29, 2023

Description

This PR automates the upload to PyPI. It relies on PyPAs trusted publishing implementation. This means that we do not need to attach any tokens etc to the environment.

A special environment ('publish-pypi') on GitHub for running the job will be created. Inside this environment there will be a requirement for a dev to approve one final time before uploading to PyPI. This means that the dev will have an opportunity to review the build artifact on GitHub (if they so wish) before uploading to PyPI.

Related Issues

#748

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b733b3a) 78.54% compared to head (705f8d7) 78.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files          81       81           
  Lines        5080     5080           
=======================================
  Hits         3990     3990           
  Misses       1090     1090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nenb nenb requested a review from rec August 29, 2023 15:10
@nenb nenb merged commit b5f187d into superduper-io:main Aug 29, 2023
@nenb nenb deleted the automate-pypi branch August 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants