Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command sddb release #798

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Add command sddb release #798

merged 1 commit into from
Aug 28, 2023

Conversation

rec
Copy link
Contributor

@rec rec commented Aug 28, 2023

Additional Notes or Comments

The two "new" dependencies were actually indirect dependencies already, but I added them because we are now explicitly depending on these libraries.

@rec rec requested a review from nenb August 28, 2023 10:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.09% ⚠️

Comparison is base (22fee14) 78.56% compared to head (b685951) 78.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   78.56%   78.48%   -0.09%     
==========================================
  Files          80       81       +1     
  Lines        5058     5080      +22     
==========================================
+ Hits         3974     3987      +13     
- Misses       1084     1093       +9     
Files Changed Coverage Δ
superduperdb/cli/release.py 59.09% <59.09%> (ø)
superduperdb/__init__.py 100.00% <100.00%> (ø)
superduperdb/__main__.py 69.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongjiajie
Copy link
Contributor

Does this will export to users or only developers? if it only need to be modify by developers should we separate it into dev tools? I think cli will allow users to use release am I right?

@nenb
Copy link
Contributor

nenb commented Aug 28, 2023

@zhongjiajie Good spot! At the moment, while we are under heavy-development, the line between users and developers will be a little blurry. For convenience, the CLI will contain options for both.

But you are correct! Longer-term we will need to split our CLI into user-only and dev.

Copy link
Contributor

@nenb nenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rec
Copy link
Contributor Author

rec commented Aug 28, 2023

The plan is at some point to have two tools but in practice the CLI is just for us because we haven't told anyone about it.

The one thing that third parties would do with it is to use python -m superduperdb info to report errors.

@rec rec merged commit ad77b90 into superduper-io:main Aug 28, 2023
@rec rec deleted the release branch August 28, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants