Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py 311 and 312-dev for CI #730

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

zhongjiajie
Copy link
Contributor

Description

Add python 3.10 and 3.11 for CI

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary? not necessary
  • Was external documentation updated, if necessary? correct some dev docs

Additional Notes or Comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Contributor

@thejumpman2323 thejumpman2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on very first contribution, excited for future contributions

There are some nitpicks
Thanks

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@@ -30,7 +30,7 @@ jobs:
matrix:
# "macos-latest" removed for now as Docker action is slow
os: [ "ubuntu-latest" ] # TODO: add "windows-latest"
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12-dev"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we can support 3.11+
@nenb WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thejumpman2323 , you can approval the CI run and then it will test whether it work in 3.11

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongjiajie
we have decided to only add 3.11 in the CI,
can you remove 3.12-dev from this pr
and we can get this pr merged!

Thanks

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@zhongjiajie
Copy link
Contributor Author

Had updated

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (daedf4e) 78.41% compared to head (7d58c80) 78.42%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files          79       81    +2     
  Lines        5077     5079    +2     
=======================================
+ Hits         3981     3983    +2     
  Misses       1096     1096           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongjiajie
Copy link
Contributor Author

Good new is we pass both 3.11 and 3.12-dev test

@thejumpman2323
Copy link
Contributor

Good new is we pass both 3.11 and 3.12-dev test

Hey, Good day!
Yes, we have a passing ci with 3.11+
Great!

CONTRIBUTING.md Outdated

```shell
# Clone and change location directory of the superduperdb repository
git clone [email protected]:SuperDuperDB/superduperdb.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git clone [email protected]:<FORKED_NAME>/superduperdb.git
@zhongjiajie :)

@thejumpman2323
Copy link
Contributor

@zhongjiajie great work!
let address the two pending changes and we can merge this one
Thanks

@zhongjiajie
Copy link
Contributor Author

Removed 3.12-dev supported in CI, could you please approval the workflow run @thejumpman2323

@thejumpman2323
Copy link
Contributor

@zhongjiajie lets squash it into a single commit? and I will merge!
Thanks

@thejumpman2323 thejumpman2323 self-assigned this Aug 22, 2023
@zhongjiajie
Copy link
Contributor Author

@thejumpman2323
Copy link
Contributor

Done, FYI, you can use the button in GitHub to squash the pr's commits https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

Thanks,
It is disabled for this repository from GUI :(

@thejumpman2323 thejumpman2323 merged commit 06bf7c1 into superduper-io:main Aug 22, 2023
@zhongjiajie
Copy link
Contributor Author

Done, FYI, you can use the button in GitHub to squash the pr's commits https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

Thanks,
It is disabled for this repository from GUI :(

We should turn it on, it is sure helpful for open source project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants