-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py 311 and 312-dev for CI #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on very first contribution, excited for future contributions
There are some nitpicks
Thanks
.github/workflows/ci.yml
Outdated
@@ -30,7 +30,7 @@ jobs: | |||
matrix: | |||
# "macos-latest" removed for now as Docker action is slow | |||
os: [ "ubuntu-latest" ] # TODO: add "windows-latest" | |||
python-version: ["3.8", "3.9", "3.10"] | |||
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12-dev"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we can support 3.11+
@nenb WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thejumpman2323 , you can approval the CI run and then it will test whether it work in 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhongjiajie
we have decided to only add 3.11 in the CI,
can you remove 3.12-dev from this pr
and we can get this pr merged!
Thanks
Had updated |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
=======================================
Coverage 78.41% 78.42%
=======================================
Files 79 81 +2
Lines 5077 5079 +2
=======================================
+ Hits 3981 3983 +2
Misses 1096 1096 ☔ View full report in Codecov by Sentry. |
Good new is we pass both 3.11 and 3.12-dev test |
Hey, Good day! |
7d58c80
to
97cbfc4
Compare
CONTRIBUTING.md
Outdated
|
||
```shell | ||
# Clone and change location directory of the superduperdb repository | ||
git clone [email protected]:SuperDuperDB/superduperdb.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git clone [email protected]:<FORKED_NAME>/superduperdb.git
@zhongjiajie :)
@zhongjiajie great work! |
Removed 3.12-dev supported in CI, could you please approval the workflow run @thejumpman2323 |
@zhongjiajie lets squash it into a single commit? and I will merge! |
64d903a
to
4eec68c
Compare
Done, FYI, you can use the button in GitHub to squash the pr's commits https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests |
Thanks, |
We should turn it on, it is sure helpful for open source project |
Description
Add python 3.10 and 3.11 for CI
Related Issues
Checklist
make test
successfully?Additional Notes or Comments