Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/source url qtd #721

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Refactor/source url qtd #721

merged 2 commits into from
Aug 19, 2023

Conversation

thejumpman2323
Copy link
Contributor

@thejumpman2323 thejumpman2323 commented Aug 18, 2023

Description

This pr adds support for source url response in the query response json.

It returns the response from the chatbot along with the evidence urls (Source url) it used to come up with the answer.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@thejumpman2323 thejumpman2323 requested review from nenb and blythed August 18, 2023 11:49
@thejumpman2323 thejumpman2323 marked this pull request as ready for review August 18, 2023 11:50
Copy link
Contributor

@nenb nenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a78eb5) 79.01% compared to head (b17b9d6) 79.01%.
Report is 1 commits behind head on main.

❗ Current head b17b9d6 differs from pull request most recent head 8eca56b. Consider uploading reports for the commit 8eca56b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   79.01%   79.01%           
=======================================
  Files          79       79           
  Lines        5004     5004           
=======================================
  Hits         3954     3954           
  Misses       1050     1050           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thejumpman2323 thejumpman2323 merged commit daedf4e into superduper-io:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants