Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch optional #697

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Torch optional #697

merged 4 commits into from
Aug 15, 2023

Conversation

nenb
Copy link
Contributor

@nenb nenb commented Aug 14, 2023

(Taken directly from #695. The work was done by @rec with a minor tweak to the CI by @nenb. A new PR was created for this work due to @nenb 's challenges with git 🤕 )


This pull request removes torch from the main dependencies that get installed by default.

With the modifications in these commits, the test suite runs without torch installed, with 59.5% coverage.

We ended up with a lot of requirements files, so in an independent commit at the end, I inlined three requirements sets that are always loaded together in each case, requirements-doc, requirements-lint and requirements-test.


We need to get the download way down to deploy the web app, and this commit achieves that.

This does not add any new pip installs like superduperdb[torch] which I don't know how to do.

If someone wants to use torch, they must pip install torch themselves for the moment

@nenb nenb mentioned this pull request Aug 14, 2023
5 tasks
@nenb nenb force-pushed the torch-optional branch 2 times, most recently from 47942d0 to d87cd14 Compare August 14, 2023 16:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.06% ⚠️

Comparison is base (86fb7af) 79.65% compared to head (47942d0) 79.60%.
Report is 12 commits behind head on main.

❗ Current head 47942d0 differs from pull request most recent head 2845054. Consider uploading reports for the commit 2845054 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   79.65%   79.60%   -0.06%     
==========================================
  Files          79       79              
  Lines        4950     4937      -13     
==========================================
- Hits         3943     3930      -13     
  Misses       1007     1007              
Files Changed Coverage Δ
superduperdb/ext/transformers/model.py 73.55% <0.00%> (-0.83%) ⬇️
superduperdb/misc/classification.py 28.57% <0.00%> (ø)
superduperdb/vector_search/inmemory.py 98.03% <ø> (ø)
superduperdb/db/query_dataset.py 48.36% <100.00%> (-0.44%) ⬇️
superduperdb/misc/superduper.py 92.18% <100.00%> (-0.24%) ⬇️
superduperdb/vector_search/base.py 95.23% <100.00%> (-0.37%) ⬇️
superduperdb/vector_search/lancedb_client.py 87.91% <100.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blythed blythed merged commit 3c45320 into superduper-io:main Aug 15, 2023
@blythed blythed mentioned this pull request Aug 15, 2023
@nenb nenb deleted the torch-optional branch October 9, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants