Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hybrid data uris + records #641

Merged

Conversation

blythed
Copy link
Collaborator

@blythed blythed commented Aug 8, 2023

Description

Allows users to combine local filesystem with data in the database. Web content and s3 are downloaded
to hashlib.sha1(uri).

Related Issues

#308

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

@blythed blythed requested a review from thejumpman2323 August 8, 2023 07:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch coverage: 90.41% and project coverage change: +0.31% 🎉

Comparison is base (08d2107) 79.62% compared to head (0e8d018) 79.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   79.62%   79.93%   +0.31%     
==========================================
  Files          79       80       +1     
  Lines        4825     4865      +40     
==========================================
+ Hits         3842     3889      +47     
+ Misses        983      976       -7     
Files Changed Coverage Δ
superduperdb/base/configs.py 97.29% <ø> (ø)
superduperdb/db/base/build.py 96.00% <ø> (ø)
superduperdb/misc/files.py 80.76% <80.76%> (ø)
superduperdb/db/base/download_content.py 88.23% <87.50%> (+0.48%) ⬆️
superduperdb/db/base/download.py 84.32% <95.23%> (+4.32%) ⬆️
superduperdb/base/config.py 100.00% <100.00%> (ø)
superduperdb/container/document.py 90.66% <100.00%> (-1.12%) ⬇️
superduperdb/db/base/cursor.py 89.47% <100.00%> (+0.79%) ⬆️
superduperdb/db/base/db.py 65.00% <100.00%> (ø)
superduperdb/db/mongodb/query.py 84.78% <100.00%> (+1.69%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

superduperdb/db/base/download.py Outdated Show resolved Hide resolved
superduperdb/db/mongodb/query.py Outdated Show resolved Hide resolved
superduperdb/misc/files.py Outdated Show resolved Hide resolved
superduperdb/db/mongodb/query.py Outdated Show resolved Hide resolved
@blythed blythed force-pushed the feature/497/load-datablobs-on-the-fly branch 2 times, most recently from 2bef84d to 456c717 Compare August 8, 2023 19:50
@blythed blythed force-pushed the feature/497/load-datablobs-on-the-fly branch from 456c717 to 0e8d018 Compare August 8, 2023 19:53
@blythed blythed merged commit ad0b706 into superduper-io:main Aug 9, 2023
@blythed blythed deleted the feature/497/load-datablobs-on-the-fly branch August 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants