Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite issue, pull request templates (fix #581) #603

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

rec
Copy link
Contributor

@rec rec commented Aug 2, 2023

No description provided.

@rec rec requested review from kislerdm and nenb August 2, 2023 16:04
@rec
Copy link
Contributor Author

rec commented Aug 2, 2023

There was a comment in the original pull request about using two different text block styles - but this was deliberate!

In one case, there's a long single line that needs breaking up; in the other, there need to be more than one line.

https://yaml-multiline.info/ was very instructive.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4188041). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage        ?   79.66%           
=======================================
  Files           ?       79           
  Lines           ?     4819           
  Branches        ?        0           
=======================================
  Hits            ?     3839           
  Misses          ?      980           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nenb nenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

description: Please describe the feature in detail?
placeholder: Description here.
description: Please describe the feature in detail
placeholder: (descriptiion)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
placeholder: (descriptiion)
placeholder: (description)

@@ -6,7 +6,8 @@ body:
- type: markdown
attributes:
value: |
Thanks for your interest in SuperDuperDB. We take all feature requests seriously and will endeavour to respond in a timely manner!
Thanks for your interest in SuperDuperDB.
We take all feature requests seriously and will response as fat as possible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We take all feature requests seriously and will response as fat as possible.
We take all feature requests seriously and will respond as fast as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, fsck this is not my file at all, I overwrote my changes with the file from sklearn.

I'm going to just revert this, the original template is fine.

- type: textarea
attributes:
label: How could it be better?
description: How we could fix the documentation to solve this?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: How we could fix the documentation to solve this?
description: >
How we could fix the documentation to solve this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rec rec merged commit 0d08229 into superduper-io:main Aug 2, 2023
@rec rec deleted the issues-3 branch August 3, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants