-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remnants of langchain and update to pydantic 2 #569
Conversation
Interestingly enough, this works locally in a clean repo but fails upstream with an error that 60 seconds' work here did not repro. This isn't a priority but I'd like to keep this pull request open for a little longer so I can experimen t later in the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
@blythed I don't think we should merge this even if we fix the issue with the tests. The reason is that by pinning I don't consider @rec Let me know if you think |
Yes, I understand that entirely of course. But so far we do not have such a conflict, and the only way we will find out if someone else has this conflict is by putting it out there. If someone contacts us to complain, this is a good thing, particularly if we can quickly revert (because we aren't using the new features). "look how responsive they are!" :-D The use case for pydantic itself is strong, but unfortunately, without custom serialization, a 2.x only feature, we were unable to make it work, which is why we put it aside. (I'd be very willing to through the long and ;-) disheartening chain of reasoning there.)
So my plan was to update to 2.x but not use any features in the production code that uses it. I can explore in unit tests, behind a feature flag, to see if this really fixes our issues or not. At the same time, we can find out if this restriction is a problem for anyone. Another possibility is not to add the dependency, and I can still write the unit tests behind a feature flag checking the pydantic version. |
(Oh, I should add, I'll fix the error here anyway, whether we use this or not, but later...) |
So I pushed the fix for pydantic 2.x onto this branch but removed the change pinning pydantic 2.x to another branch so we can push this one ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quick! 🚀
Description
#565 changed requirements.txt but did not regenerate the dependencies!
This pull request fixes that, and then updates to the long-awaited
pydantic
2 which we are finally able to install.(We aren't using any Pydantic 2 features yet, and we should probably let it sit for a bit before we do in case we suddenly have to backgrade.)