Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/542/dask cluster error #543

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Bug/542/dask cluster error #543

merged 3 commits into from
Jul 26, 2023

Conversation

blythed
Copy link
Collaborator

@blythed blythed commented Jul 26, 2023

Description

In the code state in main jobs are submitted to the dask cluster, and insider each job,
the database is rebuilt using build_datalayer, based on s.CFG.

Since CFG is not changed, then CFG.distributed == True, so the job will attempt
to build another local daskcluster, add infinitum.

I fixed this configuration issue inside the function wrappers which Dask runs.

In addition, I added a utility function TaskWorkflow.watch to monitor submitted jobs.

Related Issue(s)

#542

There'a notebook testing these changes

Checklist

  • Change or addition is covered by unit and/or integration tests. If bugfix, there should be at least one test that fails pre-PR and passes after.
  • Classes and functions substantially affected by this PR have sphinx format docstrings added or updated.
  • If your changes introduce modifications to functionality, behavior, or usage of the project, please ensure that the documentation is updated accordingly.

@blythed blythed requested a review from thejumpman2323 July 26, 2023 21:15
@blythed blythed merged commit b4aeb77 into superduper-io:main Jul 26, 2023
@blythed blythed mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant