Fix a minor bug in superduper typer #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rec
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Thanks so much for doing this, particularly in writing the test.
There's one more error I'd like you to correct while you are here - in my code. :-D
return sum(hasattr(item, a) for a in cls.attrs) == count should be
return sum(hasattr(item, a) for a in cls.attrs) >= count.
It hasn't yet made a difference, but it's logically correct, so...
| def test_mongodb_typer(self, test_db): | ||
| assert MongoDbTyper.accept(test_db.db) is True | ||
|
|
||
| def test_sklearn_typer( |
| from superduperdb.misc.superduper import MongoDbTyper, SklearnTyper, TorchTyper | ||
|
|
||
|
|
||
| class TestSuperDuper: |
There was a problem hiding this comment.
No need for this class at all! That's from when we used to use unittest, back in the old, old, old days.
Make these all static functions, get rid of self, outdent them, pytest will do the rest.
There was a problem hiding this comment.
sure :) thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #520
Related Issue(s)
Checklist
sphinxformat docstrings added or updated.Additional Notes