Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage integration #460

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add code coverage integration #460

merged 1 commit into from
Jul 19, 2023

Conversation

nenb
Copy link
Contributor

@nenb nenb commented Jul 18, 2023

Description

This PR adds an integration for Codecov. The badge is not currently active as we are waiting for organisation registration. An action has also been added to automatically upload the test statistics to Codecov after every CI run. This action is currently commented and should be restored after our Codedcov account is active.

I have made some changes to the Makefile so that we can pass some additional arguments in the action to pytest. I'm not confident that I have done this correctly...

I have updated the landing page repo with badges and an SVG version of the logo,

Related Issue(s)

#388
#433

Checklist

N/A

Additional Notes

Current code coverage available here: https://gist.github.com/nenb/f981c5c90e66b1751b9e1539beb94e79

@nenb nenb requested a review from rec July 19, 2023 09:30
Copy link
Contributor

@rec rec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bet you can set your editor so it automatically makes sure that the last line in your file is not bereft of carriage return... 👑

.gitattributes Outdated Show resolved Hide resolved
# uses: codecov/[email protected]
# with:
# file: ./coverage.xml
# env_vars: RUNNER_OS,PYTHON_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env_vars are a single string separated by commas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems so. I based this on the action from the xarray repo and this is the documentation

.github/workflows/ci.yml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@nenb nenb marked this pull request as ready for review July 19, 2023 09:56
@nenb nenb merged commit 5616d7a into superduper-io:main Jul 19, 2023
@nenb nenb deleted the add-codecov branch July 19, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants