Refactor integration test fixtures #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenb
force-pushed
the
refactor-test-fixtures
branch
from
ca52bb5 to
849c93f
Compare
nenb
commented
Jul 17, 2023
nenb
commented
Jul 17, 2023
nenb
force-pushed
the
refactor-test-fixtures
branch
2 times, most recently
from
ea8cf76 to
f1cebe3
Compare
nenb
requested review from
blythed,
thejumpman2323 and
rec
and removed request for
blythed
nenb
force-pushed
the
refactor-test-fixtures
branch
from
f1cebe3 to
50f1de7
Compare
blythed
approved these changes
Jul 18, 2023
rec
reviewed
Jul 18, 2023
nenb
force-pushed
the
refactor-test-fixtures
branch
from
50f1de7 to
098c5d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the test fixtures. It creates separate
conftest.pyfiles for the integration and unittests,and then simplifies the fixtures in the
conftest.pyfile for the integration tests. This was necessary asthere were so many layered fixtures that it was hard to tell what the initial state was before any test ran.
The refactor of the test fixtures also led to some changes in the original tests. I do not believe that I have
altered them in any substantial way, but they should be checked just in case.
I have also refactored the
serverAPI slightly, to make it more amenable to testing. I don't believe that this has any major impact on the code.A later PR will do something similar for the unittests.
Related Issue(s)
#388
Checklist
sphinxformat docstrings added or updated.Additional Notes
The project really needs to figure out what it means by integration and unittests! A bunch of the current 'unittests' take longer than the integration tests, and have at least as much coupling to a live database service.