Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert tasks config compute local override #1722

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Revert tasks config compute local override #1722

merged 5 commits into from
Jan 31, 2024

Conversation

kartik4949
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit-testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (e77ed5c) 66.59%.
Report is 1419 commits behind head on main.

❗ Current head e77ed5c differs from pull request most recent head a8f47e1. Consider uploading reports for the commit a8f47e1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1722       +/-   ##
===========================================
- Coverage   80.33%   66.59%   -13.75%     
===========================================
  Files          95      122       +27     
  Lines        6602     8750     +2148     
===========================================
+ Hits         5304     5827      +523     
- Misses       1298     2923     +1625     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kartik4949 kartik4949 requested a review from blythed January 31, 2024 15:43
@blythed blythed merged commit 32b3a17 into superduper-io:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants