Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace identifier with model in openai models #1720

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Replace identifier with model in openai models #1720

merged 1 commit into from
Feb 1, 2024

Conversation

kartik4949
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit-testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (0c58eb1) 57.75%.
Report is 1424 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1720       +/-   ##
===========================================
- Coverage   80.33%   57.75%   -22.59%     
===========================================
  Files          95      122       +27     
  Lines        6602     8753     +2151     
===========================================
- Hits         5304     5055      -249     
- Misses       1298     3698     +2400     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kartik4949 kartik4949 merged commit 81451de into superduper-io:main Feb 1, 2024
2 checks passed
@kartik4949 kartik4949 deleted the fix/openai_embedding_client_kwargs branch February 1, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants