Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client kwargs in openai #1708

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add client kwargs in openai #1708

merged 1 commit into from
Jan 26, 2024

Conversation

kartik4949
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit-testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (75e33e4) 78.76%.
Report is 1411 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   80.33%   78.76%   -1.58%     
==========================================
  Files          95      122      +27     
  Lines        6602     8749    +2147     
==========================================
+ Hits         5304     6891    +1587     
- Misses       1298     1858     +560     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kartik4949 kartik4949 requested a review from blythed January 26, 2024 07:09
@blythed blythed merged commit a4252f5 into superduper-io:main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants