Move downloads config and add extra options #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
force-pushed
the
features/sklearn-demo
branch
from
1a3ff14 to
d92f1c4
Compare
blythed
commented
Jan 23, 2024
| @@ -69,7 +69,7 @@ def pickle_decode(b: bytes, info: t.Optional[t.Dict] = None) -> t.Any: | |||
|
|
|||
|
|
|||
| def dill_encode(object: t.Any, info: t.Optional[t.Dict] = None) -> bytes: | |||
| return dill.dumps(object) | |||
| return dill.dumps(object, recurse=True) | |||
There was a problem hiding this comment.
Important so that saving from jupyter works.
blythed
commented
Jan 23, 2024
| @@ -177,7 +177,10 @@ def build_datalayer(cfg=None, databackend=None, **kwargs) -> Datalayer: | |||
|
|
|||
| # Update configuration with keyword arguments. | |||
| for k, v in kwargs.items(): | |||
| cfg.force_set(k, v) | |||
| if '__' in k: | |||
| getattr(cfg, k.split('__')[0]).force_set(k.split('__')[1], v) | |||
There was a problem hiding this comment.
Allows developers to set deeper parameters.
blythed
commented
Jan 23, 2024
| @dc.dataclass | ||
| class Downloads(BaseConfigJSONable): | ||
| folder: t.Optional[str] = None | ||
| n_workers: int = 0 |
There was a problem hiding this comment.
Set these parameters here not in some collection somewhere.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1702 +/- ##
==========================================
- Coverage 80.33% 78.89% -1.45%
==========================================
Files 95 122 +27
Lines 6602 8736 +2134
==========================================
+ Hits 5304 6892 +1588
- Misses 1298 1844 +546 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit-testingandmake integration-testingsuccessfully?Additional Notes or Comments