Added Mongodb Atlas vector searcher #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
reviewed
Dec 31, 2023
| @@ -28,6 +29,7 @@ | |||
| vector_searcher_implementations = { | |||
| 'lance': LanceVectorSearcher, | |||
| 'in_memory': InMemoryVectorSearcher, | |||
| 'mongodb': MongoAtlasVectorSearcher, | |||
blythed
reviewed
Dec 31, 2023
superduperdb/vector_search/base.py
Outdated
|
|
||
| class BaseVectorSearcher(ABC): | ||
| def create_index(self, vi: 'VectorIndex', db: 'Datalayer'): |
blythed
reviewed
Dec 31, 2023
blythed
reviewed
Dec 31, 2023
blythed
reviewed
Dec 31, 2023
superduperdb/vector_search/atlas.py
Outdated
| print(json.dumps(index_definition, indent=2)) | ||
| db.command(index_definition) | ||
|
|
||
| def create_index(self, vi: 'VectorIndex', db: 'Datalayer'): |
There was a problem hiding this comment.
This function should be private and not called from outside.
In __init__ we need a check: "does this index exist". If not, then create.
See the description in the issue: #1605
jieguangzhou
reviewed
Jan 2, 2024
blythed
reviewed
Jan 2, 2024
blythed
reviewed
Jan 2, 2024
blythed
approved these changes
Jan 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
- Coverage 80.33% 80.27% -0.07%
==========================================
Files 95 116 +21
Lines 6602 8218 +1616
==========================================
+ Hits 5304 6597 +1293
- Misses 1298 1621 +323 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #1605
Related Issues
Checklist
make unit-testingandmake integration-testingsuccessfully?Additional Notes or Comments