Artifacts from URIs and stack refactorings #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 80.33% 80.53% +0.19%
==========================================
Files 95 111 +16
Lines 6602 7884 +1282
==========================================
+ Hits 5304 6349 +1045
- Misses 1298 1535 +237 ☔ View full report in Codecov by Sentry. |
blythed
force-pushed
the
feature/artifacts-from-imports-and-uris
branch
4 times, most recently
from
5714bea to
3050fc8
Compare
blythed
force-pushed
the
feature/artifacts-from-imports-and-uris
branch
from
3050fc8 to
58cc998
Compare
fazlulkarimweb
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to extract a stack from a JSON, YAML or dictionary.
In order to make this possible, we need a broader conception of serializer which I provided in a refactoring
of the
Serializerclass. This required moving around some arguments.