Feature/additional parameters options predict #1546
Conversation
blythed
force-pushed
the
feature/additional-parameters-options-predict
branch
6 times, most recently
from
618f980 to
9e6293f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1546 +/- ##
==========================================
- Coverage 80.33% 80.30% -0.04%
==========================================
Files 95 110 +15
Lines 6602 7691 +1089
==========================================
+ Hits 5304 6176 +872
- Misses 1298 1515 +217 ☔ View full report in Codecov by Sentry. |
blythed
force-pushed
the
feature/additional-parameters-options-predict
branch
from
9e6293f to
d241c25
Compare
| @@ -722,6 +722,19 @@ def _delete(self, *args, **kwargs): | |||
| def execute(self, db): | |||
| return db.databackend.conn.table(self.identifier).execute() | |||
|
|
|||
| def model_update( | |||
There was a problem hiding this comment.
Haven't implemented this for SQL yet.
| :param vector_index: The vector index to use | ||
| :param n: The number of results to return | ||
| """ | ||
|
|
||
| r: Document | ||
| r: t.Union[t.Dict, Document] |
There was a problem hiding this comment.
This makes it easier to pass data to vector-search.
| 'type_id': item.type_id, | ||
| 'identifier': item.identifier, | ||
| 'version': getattr(item, 'version', None), | ||
| def _serialize(item: t.Any, serialize_variables: bool = True): |
There was a problem hiding this comment.
This function was not flexible enough and was overly complicated for what it did.
This should make it easier to understand.
| return self.deserialize(r) # rebuild new class instance | ||
|
|
||
| def dict(self) -> t.Dict[str, t.Any]: | ||
| return asdict(self) | ||
|
|
||
|
|
||
| class Variable: |
There was a problem hiding this comment.
This class allows queries to be included in a model,
and "crystallized" at runtime.
blythed
force-pushed
the
feature/additional-parameters-options-predict
branch
from
d241c25 to
3ca2402
Compare
|
Merging so that we can push ahead with this one. If comments/ feedback are relevant we can fix after the fact. |
Description
This PR adds additional parameters to
.predictto allow single outputs to be saved back into the database.In addition, this adds a few new
_Predictordescendants which allow users to implement search and easier model chaining.Related Issues
Checklist
make testsuccessfully?Additional Notes or Comments