Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in creating stack of functionality #1541

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix bugs in creating stack of functionality #1541

merged 1 commit into from
Dec 13, 2023

Conversation

blythed
Copy link
Collaborator

@blythed blythed commented Dec 13, 2023

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@blythed blythed force-pushed the bug/stack-post-create branch from 7fb1364 to 8a18cc3 Compare December 13, 2023 10:07
@blythed blythed changed the title Fix projection args in MongoDB Atlas Vector Search Fix bugs in creating stack of functionality Dec 13, 2023
@blythed blythed force-pushed the bug/stack-post-create branch 2 times, most recently from bc22ad1 to afc6b81 Compare December 13, 2023 10:21
@blythed blythed force-pushed the bug/stack-post-create branch from afc6b81 to 9215ccf Compare December 13, 2023 14:11
@fnikolai
Copy link
Collaborator

Plz Update Changelog

@blythed
Copy link
Collaborator Author

blythed commented Dec 13, 2023 •
edited by fnikolai
Loading

Plz Update Changelog

No new functionality

@fnikolai
Copy link
Collaborator

Plz Update Changelog

No new functionality

In Bug Fixes section

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (9215ccf) 80.18%.
Report is 1308 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
- Coverage   80.33%   80.18%   -0.15%     
==========================================
  Files          95      107      +12     
  Lines        6602     7486     +884     
==========================================
+ Hits         5304     6003     +699     
- Misses       1298     1483     +185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fazlulkarimweb
fazlulkarimweb approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@fazlulkarimweb fazlulkarimweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@fazlulkarimweb fazlulkarimweb merged commit 46605fb into superduper-io:main Dec 13, 2023
2 checks passed
@blythed blythed deleted the bug/stack-post-create branch June 1, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazlulkarimweb fazlulkarimweb fazlulkarimweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blythed @fnikolai @codecov-commenter @fazlulkarimweb