Add ray compute #1526
Merged
Add ray compute #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
reviewed
Dec 11, 2023
blythed
requested changes
Dec 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
- Coverage 80.33% 80.23% -0.11%
==========================================
Files 95 111 +16
Lines 6602 7741 +1139
==========================================
+ Hits 5304 6211 +907
- Misses 1298 1530 +232 ☔ View full report in Codecov by Sentry. |
|
Plz Update Changelog |
blythed
reviewed
Dec 17, 2023
| - "6379:6379" | ||
| environment: | ||
| SUPERDUPERDB_DATA_BACKEND: 'mongodb://superduper:superduper@mongodb:27017/test_db' | ||
| command: |
There was a problem hiding this comment.
Shouldn't we add this to dependencies as in dask?
| # Change the default value | ||
| from superduperdb.backends.ray.compute import RayComputeBackend | ||
|
|
||
| working_dir = Path(__file__).parents[1] |
There was a problem hiding this comment.
Why not use the client in the docker-compose?
blythed
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1356 fix
Related Issues
Checklist
make testsuccessfully?Additional Notes or Comments