Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typo in README.md #1517

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Minor typo in README.md #1517

merged 1 commit into from
Dec 9, 2023

Conversation

kartik4949
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@kartik4949 kartik4949 requested a review from blythed December 9, 2023 08:49
blythed
blythed reviewed Dec 9, 2023
View reviewed changes
README.md Outdated
@@ -363,7 +363,7 @@ db = superduper(pymongo.MongoClient().my_db)
model = superduper(SVC())

# Predict on the selected data.
model.train(X='input_col', y='target_col', db=db, select=Collection(name='test_documents').find({'_fold': 'valid'}))
model.train(X='input_col', y='target_col', db=db, select=Collection(name='test_documents').find({'_fold': 'train'}))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intended -- to do the prediction on the hold-out set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blythed please check, its model.train

@blythed blythed closed this Dec 9, 2023
@kartik4949 kartik4949 reopened this Dec 9, 2023
@kartik4949 kartik4949 force-pushed the kartik4949-patch-1 branch 2 times, most recently from 243bf5f to f19a457 Compare December 9, 2023 15:08
@kartik4949 kartik4949 requested a review from blythed December 9, 2023 15:09
@blythed blythed merged commit babe815 into main Dec 9, 2023
@blythed blythed deleted the kartik4949-patch-1 branch December 9, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blythed blythed blythed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartik4949 @blythed