Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the testing of sql databases #1494

Merged
merged 6 commits into from
Dec 7, 2023
Merged

simplify the testing of sql databases #1494

merged 6 commits into from
Dec 7, 2023

Conversation

fnikolai
Copy link
Collaborator

@fnikolai fnikolai commented Dec 6, 2023

Description

  1. Add connection strings for the different databases we support
  2. Spin up database instance using docker-compose

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (20ce78e) 68.88%.
Report is 1276 commits behind head on main.

❗ Current head 20ce78e differs from pull request most recent head 2e83054. Consider uploading reports for the commit 2e83054 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1494       +/-   ##
===========================================
- Coverage   80.33%   68.88%   -11.46%     
===========================================
  Files          95      103        +8     
  Lines        6602     7257      +655     
===========================================
- Hits         5304     4999      -305     
- Misses       1298     2258      +960     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnikolai fnikolai marked this pull request as ready for review December 7, 2023 15:22
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
@blythed blythed merged commit 99fd07d into superduper-io:main Dec 7, 2023
2 checks passed
@fnikolai fnikolai deleted the sql-testing branch December 7, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants