Add encoders in openai model #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
+ Coverage 80.33% 80.43% +0.09%
==========================================
Files 95 103 +8
Lines 6602 7248 +646
==========================================
+ Hits 5304 5830 +526
- Misses 1298 1418 +120 ☔ View full report in Codecov by Sentry. |
5 tasks
jieguangzhou
approved these changes
Dec 3, 2023
thejumpman2323
commented
Dec 3, 2023
| return np.frombuffer(bytes, dtype=self.dtype).tolist() | ||
|
|
||
|
|
||
| def array(dtype: str, shape: t.Sequence): |
There was a problem hiding this comment.
@blythed
Im removing this one
blythed
reviewed
Dec 3, 2023
superduperdb/ext/cohere/model.py
Outdated
| @@ -32,20 +34,14 @@ class Cohere(Component, Predictor): | |||
| identifier: str = '' | |||
| version: t.Optional[int] = None | |||
| takes_context: bool = False | |||
| encoder: t.Union[Encoder, str, None] = None | |||
| encoder: t.Union[FieldType, Encoder, str, None] = None | |||
There was a problem hiding this comment.
Should be inherited from super
blythed
reviewed
Dec 3, 2023
superduperdb/ext/openai/model.py
Outdated
| @@ -47,15 +48,9 @@ class OpenAI(Component, Predictor): | |||
| identifier: str = '' | |||
| version: t.Optional[int] = None | |||
| takes_context: bool = False | |||
| encoder: t.Union[Encoder, str, None] = None | |||
| encoder: t.Union[FieldType, Encoder, str, None] = None | |||
There was a problem hiding this comment.
Already defined in the super.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make testsuccessfully?Additional Notes or Comments