Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Testing & Sandbox #1445

Merged
merged 7 commits into from
Dec 3, 2023
Merged

Notebook Testing & Sandbox #1445

merged 7 commits into from
Dec 3, 2023

Conversation

fnikolai
Copy link
Collaborator

@fnikolai fnikolai commented Dec 2, 2023

Description

  1. Remove obsolete references to sandbox
  2. Fix GitHub action for large (runtime) data.
  3. Fix Notebook CI
  4. Minor fixes to Notebooks required for the CI.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34830a7) 80.33% compared to head (116fa52) 80.59%.
Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
+ Coverage   80.33%   80.59%   +0.25%     
==========================================
  Files          95      103       +8     
  Lines        6602     7205     +603     
==========================================
+ Hits         5304     5807     +503     
- Misses       1298     1398     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai fnikolai requested a review from blythed December 3, 2023 01:13
@fnikolai fnikolai changed the title remove obsolete references to sandbox flag Notebook Testing Dec 3, 2023
@fnikolai fnikolai changed the title Notebook Testing Notebook Testing & Sandbox Dec 3, 2023
Signed-off-by: Fotis Nikolaidis <[email protected]>
Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clear output of the notebooks

Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai fnikolai requested a review from blythed December 3, 2023 10:16
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai fnikolai merged commit 22158fc into superduper-io:main Dec 3, 2023
2 checks passed
@fnikolai fnikolai deleted the update-sandbox branch December 3, 2023 16:31
fnikolai added a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Fotis Nikolaidis <[email protected]>
Former-commit-id: 22158fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants