Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update notebook openai #1431

Merged

Conversation

jieguangzhou
Copy link
Collaborator

Description

#1259

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou force-pushed the fix/update-notebook-openai branch from 5ec0fb9 to 0abf6d0 Compare November 30, 2023 08:59
@codecov-commenter
Copy link

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (0abf6d0) 67.88%.
Report is 147 commits behind head on main.

Files Patch % Lines
superduperdb/backends/dask/compute.py 47.05% 18 Missing ⚠️
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/backends/base/metadata.py 75.00% 2 Missing ⚠️
superduperdb/backends/base/artifact.py 80.00% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1431       +/-   ##
===========================================
- Coverage   80.33%   67.88%   -12.46%     
===========================================
  Files          95      103        +8     
  Lines        6602     7340      +738     
===========================================
- Hits         5304     4983      -321     
- Misses       1298     2357     +1059     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jieguangzhou jieguangzhou linked an issue Nov 30, 2023 that may be closed by this pull request
1 task
@jieguangzhou jieguangzhou merged commit 9c1167c into superduper-io:main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new version of OpenAI
3 participants