Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change listener post_load to post_create #1428

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Change listener post_load to post_create #1428

merged 1 commit into from
Nov 30, 2023

Conversation

thejumpman2323
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (a74f582) 79.69%.
Report is 146 commits behind head on main.

Files Patch % Lines
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/dask/compute.py 88.23% 4 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/backends/base/metadata.py 75.00% 2 Missing ⚠️
superduperdb/backends/base/artifact.py 80.00% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
- Coverage   80.33%   79.69%   -0.65%     
==========================================
  Files          95      103       +8     
  Lines        6602     7344     +742     
==========================================
+ Hits         5304     5853     +549     
- Misses       1298     1491     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thejumpman2323 thejumpman2323 merged commit b48c598 into superduper-io:main Nov 30, 2023
2 checks passed
@thejumpman2323 thejumpman2323 deleted the fix/listener_post_create branch November 30, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants