Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert highlevel exceptions #1426

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Revert highlevel exceptions #1426

merged 1 commit into from
Dec 1, 2023

Conversation

thejumpman2323
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@thejumpman2323 thejumpman2323 marked this pull request as draft November 29, 2023 20:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (55b1ec3) 80.47%.
Report is 153 commits behind head on main.

❗ Current head 55b1ec3 differs from pull request most recent head 6d4d2f7. Consider uploading reports for the commit 6d4d2f7 to get more accurate results

Files Patch % Lines
superduperdb/backends/base/artifact.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
+ Coverage   80.33%   80.47%   +0.13%     
==========================================
  Files          95      103       +8     
  Lines        6602     7135     +533     
==========================================
+ Hits         5304     5742     +438     
- Misses       1298     1393      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blythed blythed marked this pull request as ready for review December 1, 2023 14:00
@blythed blythed merged commit 0f56973 into superduper-io:main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants