Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dask client to remote #1424

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Revert dask client to remote #1424

merged 1 commit into from
Nov 29, 2023

Conversation

thejumpman2323
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (b2b3672) 67.82%.
Report is 143 commits behind head on main.

❗ Current head b2b3672 differs from pull request most recent head 685039d. Consider uploading reports for the commit 685039d to get more accurate results

Files Patch % Lines
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/base/artifact.py 80.00% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1424       +/-   ##
===========================================
- Coverage   80.33%   67.82%   -12.52%     
===========================================
  Files          95      103        +8     
  Lines        6602     7335      +733     
===========================================
- Hits         5304     4975      -329     
- Misses       1298     2360     +1062     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnikolai fnikolai merged commit c4c3116 into superduper-io:main Nov 29, 2023
2 checks passed
fnikolai pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants