Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add information about routes and graceful server termination #1416

Merged
merged 5 commits into from
Nov 29, 2023
Merged

add information about routes and graceful server termination #1416

merged 5 commits into from
Nov 29, 2023

Conversation

fnikolai
Copy link
Collaborator

@fnikolai fnikolai commented Nov 28, 2023

Description

  1. Print routes
  2. Change routes to not include the service prefix
  3. Add close() method to Data layer
  4. Add disconnect() method to Datastore, MetadataStore, and ArtifactStore
  5. Add information about assertions
  6. Fix issue with configuration incompatibility due to mongodb and localhost

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

Signed-off-by: Fotis Nikolaidis <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (db5748a) 79.63%.
Report is 134 commits behind head on main.

Files Patch % Lines
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/dask/compute.py 85.29% 5 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/backends/base/metadata.py 75.00% 2 Missing ⚠️
superduperdb/backends/base/artifact.py 80.00% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
- Coverage   80.33%   79.63%   -0.71%     
==========================================
  Files          95      103       +8     
  Lines        6602     7332     +730     
==========================================
+ Hits         5304     5839     +535     
- Misses       1298     1493     +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
- main
paths:
- 'examples/**'
#pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on:
  # Pull Request is needed to make sure that notebook changes are ok.
  #pull_request:
  #  branches:
  #    - main
  #  paths:
  #    - 'examples/**'
  # Nightly is needed to ensure that code and notebooks are interopeable
  #schedule:
  #  - cron: "30 1 * * *"
  # Manual is needed for on-demand validation
  workflow_dispatch:

We keep only the manual testing

@fnikolai fnikolai merged commit 487eeb1 into superduper-io:main Nov 29, 2023
2 checks passed
@fnikolai fnikolai deleted the health-endpoints branch November 29, 2023 10:20
fnikolai added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants