-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docker and partial fixes on the notebooks #1412
Conversation
Signed-off-by: Fotis Nikolaidis <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 80.33% 79.81% -0.53%
==========================================
Files 95 103 +8
Lines 6602 7276 +674
==========================================
+ Hits 5304 5807 +503
- Misses 1298 1469 +171 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Fotis Nikolaidis <[email protected]>
.[${SUPERDUPERDB_EXTRAS}] | ||
# Install user-defined dependencies | ||
ONBUILD RUN --mount=type=cache,uid=1000,target=/home/superduper/.cache/pip pip install --user -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will throw an error if requirements.txt
doesn't exist. Can't we make this an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will complicate everything. It's simpler to assume that requirements.txt
will always exist (but will empty).
Signed-off-by: Fotis Nikolaidis <[email protected]> Former-commit-id: b8d5e8a
Description
contrib
along withexamples
Related Issues
Checklist
make test
successfully?Additional Notes or Comments