Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker and partial fixes on the notebooks #1412

Merged
merged 2 commits into from
Nov 28, 2023
Merged

update docker and partial fixes on the notebooks #1412

merged 2 commits into from
Nov 28, 2023

Conversation

fnikolai
Copy link
Collaborator

@fnikolai fnikolai commented Nov 28, 2023

Description

  1. Update Dockerfile to mount contrib along with examples
  2. Update Dockerfile to include user-defined dependencies (requirements.txt)
  3. Fix the dependencies in Docker-Compose
  4. Some stylistic changes on the notebooks

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (61d7276) 79.81%.
Report is 129 commits behind head on main.

Files Patch % Lines
superduperdb/backends/base/compute.py 68.96% 9 Missing ⚠️
superduperdb/backends/dask/compute.py 85.29% 5 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/backends/base/metadata.py 66.66% 2 Missing ⚠️
superduperdb/backends/base/artifact.py 66.66% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 66.66% 1 Missing ⚠️
superduperdb/backends/ibis/data_backend.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
- Coverage   80.33%   79.81%   -0.53%     
==========================================
  Files          95      103       +8     
  Lines        6602     7276     +674     
==========================================
+ Hits         5304     5807     +503     
- Misses       1298     1469     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.[${SUPERDUPERDB_EXTRAS}]
# Install user-defined dependencies
ONBUILD RUN --mount=type=cache,uid=1000,target=/home/superduper/.cache/pip pip install --user -r requirements.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will throw an error if requirements.txt doesn't exist. Can't we make this an option?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will complicate everything. It's simpler to assume that requirements.txt will always exist (but will empty).

@fnikolai fnikolai merged commit b8d5e8a into superduper-io:main Nov 28, 2023
2 checks passed
@fnikolai fnikolai deleted the release-preparation branch November 28, 2023 14:15
fnikolai added a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Fotis Nikolaidis <[email protected]>
Former-commit-id: b8d5e8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants