Add local cluster #1403
Add local cluster #1403
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
===========================================
- Coverage 80.33% 67.12% -13.22%
===========================================
Files 95 103 +8
Lines 6602 7272 +670
===========================================
- Hits 5304 4881 -423
- Misses 1298 2391 +1093 ☔ View full report in Codecov by Sentry. |
superduperdb/base/config.py
Outdated
| None: Run all jobs in local mode i.e simple function call | ||
| local: same as above | ||
| dask+thread: Run all jobs on a local threaded dask cluster | ||
| dask+tcp:<host>:<port>: Run all jobs on a remote dask cluster |
There was a problem hiding this comment.
This looks inconsistent with the above. Please make uniform.
There was a problem hiding this comment.
what do u mean?
can u write the edited version here :)
There was a problem hiding this comment.
Should be:
"local": same as above
superduperdb/base/config.py
Outdated
| None: Run vector search on local | ||
| http://<host>:<port>: Connect a remote vector search service | ||
|
|
||
| `cdc` options: |
There was a problem hiding this comment.
What not add these in the parameter doc-strings?
superduperdb/base/config.py
Outdated
| :param backfill_batch_size: The number of rows to backfill at a time | ||
| for vector-search loading | ||
| :param compute: The URI for compute i.e 'local', 'dask+tcp://localhost:8786' | ||
| None: Run all jobs in local mode i.e simple function call |
There was a problem hiding this comment.
The ':' at the end is confusing -- is that part of the string or part of the explanation. You need to add "quotation" marks.
Description
fix ##1379
Related Issues
Checklist
make testsuccessfully?Additional Notes or Comments