Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distributed param #1377

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Remove distributed param #1377

merged 1 commit into from
Nov 24, 2023

Conversation

thejumpman2323
Copy link
Contributor

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (5b2a9a3) 79.82%.
Report is 119 commits behind head on main.

Files Patch % Lines
superduperdb/backends/base/compute.py 70.37% 8 Missing ⚠️
superduperdb/backends/dask/compute.py 87.87% 4 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/backends/base/metadata.py 66.66% 2 Missing ⚠️
superduperdb/backends/base/artifact.py 66.66% 1 Missing ⚠️
superduperdb/backends/base/data_backend.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1377      +/-   ##
==========================================
- Coverage   80.33%   79.82%   -0.52%     
==========================================
  Files          95      102       +7     
  Lines        6602     7238     +636     
==========================================
+ Hits         5304     5778     +474     
- Misses       1298     1460     +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnikolai fnikolai merged commit 6bbbc72 into superduper-io:main Nov 24, 2023
2 checks passed
fnikolai pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants