Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing workflow #1347

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Improve testing workflow #1347

merged 4 commits into from
Nov 20, 2023

Conversation

fnikolai
Copy link
Collaborator

Description

Separate the testenv_image from testenv_init.
The first one is responbie for building the sandbox image with all its dependencies.
The second initializes the docker-compose, using as based the image of the previous step.

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@fnikolai fnikolai changed the title separate image building from testenv to speedup execution time Improve testing workflow Nov 20, 2023
Makefile Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (1eca5a1) 80.39%.
Report is 77 commits behind head on main.

Files Patch % Lines
superduperdb/backends/ibis/query.py 74.21% 41 Missing ⚠️
superduperdb/backends/mongodb/query.py 83.33% 10 Missing ⚠️
superduperdb/cli/stack.py 0.00% 9 Missing ⚠️
superduperdb/base/datalayer.py 84.09% 7 Missing ⚠️
superduperdb/cdc/cdc.py 64.70% 6 Missing ⚠️
superduperdb/cli/serve.py 54.54% 5 Missing ⚠️
superduperdb/backends/sqlalchemy/metadata.py 73.33% 4 Missing ⚠️
superduperdb/base/build.py 71.42% 4 Missing ⚠️
superduperdb/backends/base/query.py 85.00% 3 Missing ⚠️
superduperdb/base/serializable.py 92.85% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   80.33%   80.39%   +0.05%     
==========================================
  Files          95      100       +5     
  Lines        6602     6887     +285     
==========================================
+ Hits         5304     5537     +233     
- Misses       1298     1350      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnikolai fnikolai requested a review from blythed November 20, 2023 17:27
@blythed blythed merged commit af9846f into superduper-io:main Nov 20, 2023
2 checks passed
@fnikolai fnikolai deleted the caching-sandbox branch November 21, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants