-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing workflow #1347
Merged
Merged
Improve testing workflow #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
fnikolai
changed the title
separate image building from testenv to speedup execution time
Improve testing workflow
Nov 20, 2023
blythed
reviewed
Nov 20, 2023
blythed
reviewed
Nov 20, 2023
blythed
reviewed
Nov 20, 2023
blythed
reviewed
Nov 20, 2023
blythed
reviewed
Nov 20, 2023
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
+ Coverage 80.33% 80.39% +0.05%
==========================================
Files 95 100 +5
Lines 6602 6887 +285
==========================================
+ Hits 5304 5537 +233
- Misses 1298 1350 +52 ☔ View full report in Codecov by Sentry. |
blythed
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the
testenv_image
fromtestenv_init
.The first one is responbie for building the sandbox image with all its dependencies.
The second initializes the docker-compose, using as based the image of the previous step.
Related Issues
Checklist
make test
successfully?Additional Notes or Comments