Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions in datalayer #1343

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Add exceptions in datalayer #1343

merged 10 commits into from
Nov 21, 2023

Conversation

thejumpman2323
Copy link
Contributor

Description

fix #1336

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 191 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (a34eae3) 67.31%.
Report is 84 commits behind head on main.

Files Patch % Lines
superduperdb/backends/ibis/query.py 73.58% 42 Missing ⚠️
superduperdb/backends/sqlalchemy/metadata.py 46.37% 37 Missing ⚠️
superduperdb/backends/mongodb/metadata.py 34.09% 29 Missing ⚠️
superduperdb/backends/mongodb/artifacts.py 9.09% 20 Missing ⚠️
superduperdb/base/config.py 66.00% 17 Missing ⚠️
superduperdb/backends/filesystem/artifacts.py 46.15% 14 Missing ⚠️
superduperdb/backends/mongodb/query.py 83.33% 10 Missing ⚠️
superduperdb/base/build.py 64.28% 5 Missing ⚠️
superduperdb/backends/base/query.py 85.71% 3 Missing ⚠️
superduperdb/base/configs.py 78.57% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1343       +/-   ##
===========================================
- Coverage   80.33%   67.31%   -13.03%     
===========================================
  Files          95      100        +5     
  Lines        6602     7203      +601     
===========================================
- Hits         5304     4849      -455     
- Misses       1298     2354     +1056     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnikolai fnikolai merged commit 88f5d0a into superduper-io:main Nov 21, 2023
2 checks passed
fnikolai pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants