Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the building system #1326

Merged
merged 3 commits into from
Nov 17, 2023
Merged

improve the building system #1326

merged 3 commits into from
Nov 17, 2023

Conversation

fnikolai
Copy link
Collaborator

Description

  1. Move testenv from test/material to deploy.
  2. Decide whether to change /etc/hosts on every testenv_init or just document it.
  3. Fix caching layer in Dockerfile

Related Issues

#1324

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 218 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (831c9d2) 79.46%.
Report is 72 commits behind head on main.

Files Patch % Lines
superduperdb/components/stack.py 0.00% 65 Missing ⚠️
superduperdb/backends/ibis/query.py 52.17% 44 Missing ⚠️
superduperdb/server/app.py 67.56% 24 Missing ⚠️
superduperdb/cli/stack.py 0.00% 9 Missing ⚠️
superduperdb/vector_search/interface.py 75.67% 9 Missing ⚠️
superduperdb/jobs/tasks.py 0.00% 8 Missing ⚠️
superduperdb/base/build.py 57.14% 6 Missing ⚠️
superduperdb/cdc/cdc.py 62.50% 6 Missing ⚠️
superduperdb/base/datalayer.py 83.33% 5 Missing ⚠️
superduperdb/cli/serve.py 54.54% 5 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   80.33%   79.46%   -0.88%     
==========================================
  Files          95      100       +5     
  Lines        6602     6822     +220     
==========================================
+ Hits         5304     5421     +117     
- Misses       1298     1401     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fotis Nikolaidis <[email protected]>
@blythed blythed merged commit 0705cc9 into superduper-io:main Nov 17, 2023
2 checks passed
@fnikolai fnikolai mentioned this pull request Nov 17, 2023
@fnikolai fnikolai deleted the update-testenv branch November 18, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants