Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge sandbox with docker-compose #1319

Merged
merged 6 commits into from
Nov 17, 2023
Merged

merge sandbox with docker-compose #1319

merged 6 commits into from
Nov 17, 2023

Conversation

fnikolai
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

Signed-off-by: Fotis Nikolaidis <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 186 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (8f856ff) 80.17%.
Report is 60 commits behind head on main.

Files Patch % Lines
superduperdb/backends/ibis/query.py 52.17% 44 Missing ⚠️
superduperdb/components/stack.py 41.53% 38 Missing ⚠️
superduperdb/server/app.py 67.56% 24 Missing ⚠️
superduperdb/vector_search/interface.py 75.67% 9 Missing ⚠️
superduperdb/jobs/tasks.py 0.00% 8 Missing ⚠️
superduperdb/base/build.py 57.14% 6 Missing ⚠️
superduperdb/cdc/cdc.py 62.50% 6 Missing ⚠️
superduperdb/base/datalayer.py 83.33% 5 Missing ⚠️
superduperdb/cli/serve.py 54.54% 5 Missing ⚠️
superduperdb/ext/utils.py 72.22% 5 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   80.33%   80.17%   -0.17%     
==========================================
  Files          95      103       +8     
  Lines        6602     7076     +474     
==========================================
+ Hits         5304     5673     +369     
- Misses       1298     1403     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>

echo "Adding vector-search to /etc/hosts"
echo 127.0.0.1 vector-search | sudo tee -a /etc/hosts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need

echo "Adding mongo to /etc/hosts"
echo 127.0.0.1 mongodb | sudo tee -a /etc/hosts

other serivce do not require us to have these thing appended

@blythed blythed merged commit 1ac5dc8 into superduper-io:main Nov 17, 2023
2 checks passed
@fnikolai fnikolai deleted the reduce-builds branch November 17, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants