Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples as submodule of superduperdb #1316

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

blythed
Copy link
Collaborator

@blythed blythed commented Nov 16, 2023

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 323 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (7b41369) 67.09%.
Report is 61 commits behind head on main.

❗ Current head 7b41369 differs from pull request most recent head 2bda44d. Consider uploading reports for the commit 2bda44d to get more accurate results

Files Patch % Lines
superduperdb/backends/ibis/query.py 21.73% 72 Missing ⚠️
superduperdb/components/stack.py 41.53% 38 Missing ⚠️
superduperdb/server/app.py 56.75% 32 Missing ⚠️
superduperdb/vector_search/interface.py 48.64% 19 Missing ⚠️
superduperdb/ext/openai/model.py 37.03% 17 Missing ⚠️
superduperdb/misc/server.py 26.08% 17 Missing ⚠️
superduperdb/vector_search/server/service.py 48.48% 17 Missing ⚠️
superduperdb/ext/utils.py 27.77% 13 Missing ⚠️
superduperdb/cdc/cdc.py 25.00% 12 Missing ⚠️
superduperdb/vector_search/server/app.py 65.71% 12 Missing ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1316       +/-   ##
===========================================
- Coverage   80.33%   67.09%   -13.25%     
===========================================
  Files          95      103        +8     
  Lines        6602     7072      +470     
===========================================
- Hits         5304     4745      -559     
- Misses       1298     2327     +1029     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fazlulkarimweb
Copy link
Collaborator

image

This submodule is a nice addition but looks a little bit off in the beginner's eye. If it could be done like this -

examples/submodule

Looking great again. When people click examples, then in the folders they will see the submodule to click again.

Just a design observation.

@blythed
Copy link
Collaborator Author

blythed commented Nov 16, 2023

image This submodule is a nice addition but looks a little bit off in the beginner's eye. If it could be done like this -

examples/submodule

Looking great again. When people click examples, then in the folders they will see the submodule to click again.

Just a design observation.

Ok, I will have to check with @fnikolai how this will work with the notebooks. I removed for now anyway, since somehow I'm not allowed to merge.

@blythed blythed force-pushed the symbolic-link branch 4 times, most recently from bbcbb50 to 7b41369 Compare November 16, 2023 15:48
@blythed blythed merged commit 6631352 into superduper-io:main Nov 17, 2023
2 checks passed
@blythed blythed deleted the symbolic-link branch November 17, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants