Repair outputs logic #1313
Merged
Repair outputs logic #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
force-pushed
the
bug/inconsistency-features-outputs
branch
2 times, most recently
from
fce1755 to
f094f53
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
===========================================
- Coverage 80.33% 65.22% -15.12%
===========================================
Files 95 100 +5
Lines 6602 6815 +213
===========================================
- Hits 5304 4445 -859
- Misses 1298 2370 +1072 ☔ View full report in Codecov by Sentry. |
blythed
force-pushed
the
bug/inconsistency-features-outputs
branch
3 times, most recently
from
bd762d4 to
2281de8
Compare
superduperdb/backends/ibis/query.py
Outdated
| @@ -147,13 +151,29 @@ def get_all_tables(self): | |||
| return tables | |||
|
|
|||
| def _get_all_fields(self, db): | |||
| lookup = ( | |||
| self.renamings | |||
| ) # dict(zip(self.renamings.values(), self.renamings.keys())) | |||
There was a problem hiding this comment.
we can remove executable code!
There was a problem hiding this comment.
Yes, my bad, a mistake.
thejumpman2323
suggested changes
Nov 17, 2023
superduperdb/backends/ibis/query.py
Outdated
| @@ -357,6 +402,15 @@ def __getitem__(self, other): | |||
| other, members=self.members, collection=self.table_or_collection | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def _get_query_linker(cls, table_or_collection, members): | |||
| out = cls( | |||
blythed
force-pushed
the
bug/inconsistency-features-outputs
branch
from
2281de8 to
94ff2cd
Compare
thejumpman2323
approved these changes
Nov 17, 2023
blythed
force-pushed
the
bug/inconsistency-features-outputs
branch
from
94ff2cd to
ba2391d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Featurizeandfeaturesreplaced everywhere withoutputsoutputsnow supportedibisview.relabel