Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version outputs in target documents and rows #1299

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

blythed
Copy link
Collaborator

@blythed blythed commented Nov 15, 2023

We should be doing this already, but Rome wasn't built in a day...

  • In MongoDB, outputs are versioned in the documents, that means that we won't get inconsistencies, when a model is rolled back or updated
  • In Ibis, there is one table per Model version.

@blythed blythed force-pushed the feature/versioned-model-outputs branch 3 times, most recently from 99d021e to 712dda0 Compare November 20, 2023 13:18
@blythed blythed force-pushed the feature/versioned-model-outputs branch from 712dda0 to b2802f0 Compare November 20, 2023 13:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (b2802f0) 80.39%.
Report is 76 commits behind head on main.

Files Patch % Lines
superduperdb/backends/ibis/query.py 74.21% 41 Missing ⚠️
superduperdb/backends/mongodb/query.py 83.33% 10 Missing ⚠️
superduperdb/cli/stack.py 0.00% 9 Missing ⚠️
superduperdb/base/datalayer.py 84.09% 7 Missing ⚠️
superduperdb/cdc/cdc.py 64.70% 6 Missing ⚠️
superduperdb/cli/serve.py 54.54% 5 Missing ⚠️
superduperdb/backends/sqlalchemy/metadata.py 73.33% 4 Missing ⚠️
superduperdb/base/build.py 71.42% 4 Missing ⚠️
superduperdb/backends/base/query.py 85.00% 3 Missing ⚠️
superduperdb/base/serializable.py 92.85% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   80.33%   80.39%   +0.05%     
==========================================
  Files          95      100       +5     
  Lines        6602     6887     +285     
==========================================
+ Hits         5304     5537     +233     
- Misses       1298     1350      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blythed blythed merged commit bcf345a into superduper-io:main Nov 20, 2023
2 of 4 checks passed
@blythed blythed linked an issue Nov 20, 2023 that may be closed by this pull request
@blythed blythed deleted the feature/versioned-model-outputs branch June 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save the outputs of models with versions
2 participants