Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask integration in end-to-end testing #1295

Merged
merged 18 commits into from
Nov 15, 2023
Merged

Add dask integration in end-to-end testing #1295

merged 18 commits into from
Nov 15, 2023

Conversation

fnikolai
Copy link
Collaborator

Description

Add end-to-end tests for dask and vector-search

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make test successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 177 lines in your changes are missing coverage. Please review.

Comparison is base (34830a7) 80.33% compared to head (0b3e23b) 79.62%.
Report is 51 commits behind head on main.

Files Patch % Lines
superduperdb/backends/ibis/query.py 52.17% 44 Missing ⚠️
superduperdb/components/stack.py 41.53% 38 Missing ⚠️
superduperdb/server/app.py 69.11% 21 Missing ⚠️
superduperdb/misc/server.py 26.66% 11 Missing ⚠️
superduperdb/vector_search/interface.py 67.64% 11 Missing ⚠️
superduperdb/base/build.py 57.14% 6 Missing ⚠️
superduperdb/cdc/cdc.py 62.50% 6 Missing ⚠️
superduperdb/cli/serve.py 54.54% 5 Missing ⚠️
superduperdb/backends/sqlalchemy/metadata.py 73.33% 4 Missing ⚠️
superduperdb/cli/stack.py 55.55% 4 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   80.33%   79.62%   -0.72%     
==========================================
  Files          95      103       +8     
  Lines        6602     7027     +425     
==========================================
+ Hits         5304     5595     +291     
- Misses       1298     1432     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thejumpman2323 thejumpman2323 changed the title add dask and vector-search integrations Add dask and vector-search integrations Nov 15, 2023
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@thejumpman2323 thejumpman2323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from some small schanges, im good!

@fnikolai fnikolai changed the title Add dask and vector-search integrations Add dask integration in end-to-end testing Nov 15, 2023
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
Signed-off-by: Fotis Nikolaidis <[email protected]>
@fnikolai fnikolai merged commit 80207a7 into superduper-io:main Nov 15, 2023
2 checks passed
@fnikolai fnikolai deleted the e2e-dask branch November 15, 2023 10:34
fnikolai added a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Fotis Nikolaidis <[email protected]>
Former-commit-id: 80207a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants